rusackas commented on pull request #14529: URL: https://github.com/apache/superset/pull/14529#issuecomment-840339312
@villebro You uncovered something gross... this PR only fixes SOME of the controls. A bunch of controls use `ControlHeader` from `superset`, and some use `ControlHeader` from `superset-ui` 🤦 Proposed approach: 1) Merge this (it fixes several) 2) Merge a PR on superset-ui (which I'll open soon) that does the same thing with the `ControlHeader` on that side 3) Bump in the `@superset-ui/chart-controls` package, and use that updated `ControlHeader` from `superset-ui` everywhere, and delete the duplicate one (this one!) from Superset. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
