mayurnewase commented on pull request #14393: URL: https://github.com/apache/superset/pull/14393#issuecomment-840994008
> > Wouldn't it be useful to have the schema included in this constraint? In most cases it is only the fully qualified db.schema.table name that really is unique by definition. > > Right, and eventually I'd like to see us supporting catalogs as well. Presto's hierarchy is `catalog.schema.table`. > > > The proposed approach of having a custom unique dataset name serves the same purpose, though. > > For sure! Specially with Google spreadsheets, that when added have the full URL as the name. This is definitely a step in the right direction! > > I'm writing a SIP (Superset Improvement Proposal) about datasets, proposing the creation of a separate model for tables and datasets, instead of having a single `SqlaTable` model. It's nice to see that some of the ideas I want to propose are needed. :) @betodealmeida So should I complete this or not? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
