AAfghahi commented on a change in pull request #14646:
URL: https://github.com/apache/superset/pull/14646#discussion_r632681578
##########
File path: superset-frontend/src/views/CRUD/data/database/types.ts
##########
@@ -21,6 +21,16 @@ type DatabaseUser = {
last_name: string;
};
+type DatabaseParameters = {
+ database: string;
+ engine: string;
+ host: string;
+ password?: string;
+ port: number;
+ query: Object;
Review comment:
I think it is better to use the query props here, which I think you can
import.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
