eschutho commented on a change in pull request #14646:
URL: https://github.com/apache/superset/pull/14646#discussion_r632758469
##########
File path: superset/models/core.py
##########
@@ -222,6 +223,17 @@ def unique_name(self) -> str:
def url_object(self) -> URL:
return make_url(self.sqlalchemy_uri_decrypted)
+ @property
+ def parameters(self) -> Optional[Dict[str, Any]]:
+ # Build parameters if db_engine_spec is a subclass of
BasicParametersMixin
+ parameters = {"engine": self.backend}
Review comment:
so for sqlalchemy forms, we're only going to return engine? Maybe that
should be the only required type then, it looks like.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
