michael-s-molina commented on a change in pull request #14644:
URL: https://github.com/apache/superset/pull/14644#discussion_r633541298
##########
File path: superset-frontend/src/components/Menu/LanguagePicker.tsx
##########
@@ -16,10 +16,12 @@
* specific language governing permissions and limitations
* under the License.
*/
-import React, { useState } from 'react';
-import { Select } from 'src/common/components';
-import { styled, useTheme } from '@superset-ui/core';
-import Icons from 'src/components/Icons';
Review comment:
Yes. All menus are using the old implementation. If I change to the new
one just here, we have differences in icons sizes. When we migrate the menu
icons, then we should also migrate the icon in `LanguagePicker`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
