bigdata-memory commented on a change in pull request #600:
URL: https://github.com/apache/incubator-teaclave/pull/600#discussion_r787262026
##########
File path: cmake/scripts/test.sh
##########
@@ -97,7 +97,7 @@ run_functional_tests() {
pushd ${TEACLAVE_SERVICE_INSTALL_DIR}
./teaclave_authentication_service &
./teaclave_storage_service &
- sleep 3 # wait for authentication and storage service
+ sleep 10 # wait for authentication and storage service
Review comment:
IMO, it may suggest a new feature similar to readiness probe of k8s.
##########
File path: examples/python/builtin_gbdt_train.py
##########
@@ -103,6 +103,13 @@ def gbdt(self):
print("[+] invoking task")
client.invoke_task(task_id)
+ # If you feel like you don't want to wait for the task to finish
+ # or something unexpected happens,
+ # you may uncomment the following lines to cancel the task
+ # time.sleep(3)
+ # print("[+] canceling task")
Review comment:
This code comment could be removed if it is incomplete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@teaclave.apache.org
For additional commands, e-mail: notifications-h...@teaclave.apache.org
