ya0guang commented on a change in pull request #603:
URL: https://github.com/apache/incubator-teaclave/pull/603#discussion_r795997582
##########
File path: types/src/function.rs
##########
@@ -38,13 +40,15 @@ impl FunctionInput {
#[derive(Debug, Deserialize, Serialize)]
pub struct FunctionOutput {
pub name: String,
+ pub option: bool,
pub description: String,
}
impl FunctionOutput {
- pub fn new(name: impl Into<String>, description: impl Into<String>) ->
Self {
+ pub fn new(name: impl Into<String>, option: bool, description: impl
Into<String>) -> Self {
Review comment:
Do we need to think about future compatibility? For example, we may have
some "decrypted" input file, and we can have an argument called `property`, and
`property='do'` stands for decrypted, optional.
##########
File path: services/proto/src/teaclave_frontend_service.rs
##########
@@ -1072,6 +1074,7 @@ impl std::convert::TryFrom<proto::FunctionOutput> for
FunctionOutput {
fn try_from(proto: proto::FunctionOutput) -> Result<Self> {
let ret = Self {
name: proto.name,
+ option: proto.option,
Review comment:
In Python API, `option` is the 3rd argument. Do you think it's better to
make them consistent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@teaclave.apache.org
For additional commands, e-mail: notifications-h...@teaclave.apache.org
