mssun commented on PR #661: URL: https://github.com/apache/incubator-teaclave/pull/661#issuecomment-1291404332
Hi @henrysun007, thanks for the PR. The reason we choose to put in the `common` directory is that we have changed `rusty_leveldb` a lot, and we don't have any plan to upstream the changes. Therefore, we'd like to keep it in the Teaclave codebase as a part of Teaclave. I saw you're using a submodule for the changes (which is not under the Apache organization). This may be not suitable for further maintenance. Can you PR the changes of the `rusty_leveldb_sgx` in the source code? For the name of the `common` directory, if you have better suggestion. Please advise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@teaclave.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@teaclave.apache.org For additional commands, e-mail: notifications-h...@teaclave.apache.org
