wang384670111 opened a new pull request, #424: URL: https://github.com/apache/incubator-teaclave-sgx-sdk/pull/424
[ SIDE_EFFECT.fetch_add(self.0, atomic::Ordering::SeqCst);](https://github.com/apache/incubator-teaclave-sgx-sdk/blob/495b91f6e690a8c7a3b94241ba58eb44cc22739d/sgx_tstd/hashbrown/benches/bench.rs#L56),https://github.com/apache/incubator-teaclave-sgx-sdk/blob/495b91f6e690a8c7a3b94241ba58eb44cc22739d/samplecode/tls/tlsclient/enclave/src/lib.rs#L245,https://github.com/apache/incubator-teaclave-sgx-sdk/blob/495b91f6e690a8c7a3b94241ba58eb44cc22739d/samplecode/tls/tlsserver/enclave/src/lib.rs#L181 I think the use of ordering here is incorrect, AtomicUsize is used here for counting, not to synchronize access to other shared variables. Therefore, only Relaxed needs to be used here to ensure the correctness of the program. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@teaclave.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@teaclave.apache.org For additional commands, e-mail: notifications-h...@teaclave.apache.org
