henrysun007 commented on code in PR #705:
URL:
https://github.com/apache/incubator-teaclave/pull/705#discussion_r1260770032
##########
cmake/tomls/Cargo.sgx_untrusted_app.toml:
##########
@@ -45,6 +45,7 @@ sgx_tprotected_fs = { path =
"../../../third_party/rust-sgx-sdk/sgx_protected_fs
sgx_tse = { path = "../../../third_party/rust-sgx-sdk/sgx_tse" }
sgx_types = { path = "../../../third_party/rust-sgx-sdk/sgx_types" }
sgx_urts = { path = "../../../third_party/rust-sgx-sdk/sgx_urts" }
+tonic = { git =
"https://github.com/apache/incubator-teaclave-crates"; }
Review Comment:
Put the crate with rustface and rusty-machine together.
##########
cmake/tomls/Cargo.sgx_trusted_lib.toml:
##########
@@ -72,3 +72,4 @@ rusty-machine = { git =
"https://github.com/apache/incubator-teaclave-crates
tantivy = { git =
"https://github.com/apache/incubator-teaclave-crates"; }
tokio = { git = "https://github.com/tokio-rs/tokio.git";, tag =
"tokio-1.24.0"}
yasna = { git = "https://github.com/sccommunity/yasna.rs";, branch
= "teaclave-sgx" }
+tonic = { git =
"https://github.com/apache/incubator-teaclave-crates"; }
Review Comment:
Please keep the crate name in alphabetical order.
##########
examples/rust/builtin_echo/Cargo.toml:
##########
@@ -30,5 +30,6 @@ pem = "0.7.0"
[patch.crates-io]
h2 = { git = "https://github.com/hyperium/h2";, tag = "v0.3.19" }
+tonic = { git =
"https://github.com/apache/incubator-teaclave-crates"; }
Review Comment:
Keep the crate name in alphabetical order.
##########
examples/rust/builtin_ordered_set_intersect/Cargo.toml:
##########
@@ -30,5 +30,6 @@ pem = "0.7.0"
[patch.crates-io]
h2 = { git = "https://github.com/hyperium/h2";, tag = "v0.3.19" }
+tonic = { git =
"https://github.com/apache/incubator-teaclave-crates"; }
Review Comment:
Keep the crate name in alphabetical order.
##########
sdk/rust/Cargo.toml:
##########
@@ -41,5 +41,6 @@ tokio = { version = "1.0", features =
["rt-multi-thread", "time"
[patch.crates-io]
h2 = { git = "https://github.com/hyperium/h2";, tag = "v0.3.19" }
+tonic = { git =
"https://github.com/apache/incubator-teaclave-crates"; }
Review Comment:
Keep the crate name in alphabetical order.
##########
examples/rust/sequential_functions/Cargo.toml:
##########
@@ -31,5 +31,6 @@ teaclave_client_sdk = { path = "../../../sdk/rust/" }
[patch.crates-io]
h2 = { git = "https://github.com/hyperium/h2";, tag = "v0.3.19" }
+tonic = { git =
"https://github.com/apache/incubator-teaclave-crates"; }
Review Comment:
Keep the crate name in alphabetical order.
##########
config/build.config.toml:
##########
@@ -29,8 +29,8 @@ auditor_public_keys = [
{ path =
"config/keys/auditors/albus_dumbledore/albus_dumbledore.public.pem"},
]
-# RPC max message size
-rpc_max_message_size = 409600
+# gRPC max message size
+grpc_max_message_size = 4194304
Review Comment:
It seems not necessary to change the name. The old name is used in many
places. It is better to keep them there.
##########
services/management/enclave/src/service.rs:
##########
@@ -938,7 +939,11 @@ impl TeaclaveManagementService {
.connect()
.await
.map_err(|e| anyhow!("Failed to connect to storage service, {:?}",
e))?;
- let storage_client =
Arc::new(Mutex::new(TeaclaveStorageClient::new(channel)));
+ let storage_client = Arc::new(Mutex::new(
+ TeaclaveStorageClient::new(channel)
Review Comment:
Calling those two max functions with the same parameter seems not smart. How
about putting the default configuration in the constructor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@teaclave.apache.org
For additional commands, e-mail: notifications-h...@teaclave.apache.org
