Yicong-Huang commented on PR #4005: URL: https://github.com/apache/texera/pull/4005#issuecomment-3458394025
> Thanks @Xiao-zhen-Liu ! I've updated the target-version to py39-py912 and pushed the newly reformatted amber/src/main/python/proto/org/apache/amber/engine/architecture/rpc/**init**.py. The CI should be passing now. Ahh that's a problem. the file you modified format (and all files under `amber/src/main/python/proto/` folder) is automatically generated by protoc. so that means if we generate it again, the format will be lost, and CI will complain about it. So a practice is that we should never manually modify a generated file. Could you config the formatter to tolerant these files? If hard to align the format requirement, one option is we can configure the formatter to ignore this directory `amber/src/main/python/proto/` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
