mengw15 commented on PR #4024: URL: https://github.com/apache/texera/pull/4024#issuecomment-3529836773
> LGTM in general, but there are some issues with the readability of this PR. Please address them. > > Also a few general comments: > > Instead of a simple move of the code, you also made some code changes to the type ops which supposedly will improve those existing code. Please also mention these changes in the PR description. > > Since you mentioned you used ChatGPT to author some of those code, I assume some of those code improvements are generated by AI? If that is the case, please make sure you understand all these generated code. For example, there are some technical terms in the comments that do not make sense and hinder readability. > > As there is currently no test case for Aggregate operator, it would be good if you can also do some manual testing of this operator to make sure this operator works as expected on different attribute types and agg operations, especially if their are code logic changes. > > @mengw15 for the review comments you left, if your questions are addressed by @carloea2, please resolve them. it seems like I do not have the permission to resolve comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
