AnzhiZhang commented on PR #4018: URL: https://github.com/apache/texera/pull/4018#issuecomment-3534210796
> > @Yicong-Huang Just want to confirm: does each contributor need to manually add the PR in the corresponding issue before we close the issue? > > There are two purposes: > > 1. The PRs and issues should be bidirectionally referenced. Even if a PR is closed (not merged), it will be good to reference it to the issue, so we know there is an attempt on the issue. If there is a followup PR on a closed issue, it will be good to reference them as well. > 2. We need to manage life cycles of PRs and issues. I.e., we do not want an issue to be fixed but not closed. > > So to achieve those two purposes, devs can either: > > 1. Do things manually: manually reference PRs and issues using github UI; manually close issues if PR is merged, etc. > 2. Use `fixes: #xxx` or other syntax sugars in PR description, to automatically 1) link to an issue and 2) close the issue when the PR is merged. Thanks for explaining. This PR updates the document as a follow-up to the previous issue and its solution. Since it’s a very small change and the earlier issue already provided the necessary context, I didn’t create a separate issue for it. The mention and the link are different: mentioning an issue/PR is simply referencing a previous discussion or solution, while linking an issue allows it to be automatically closed when the PR is merged. Sometimes a single issue may be linked to multiple PRs working on it, and other times we may just want to mention it without creating a link. Consider this is much separated from reorganization, and that issue does not link to any PR, I just used the mention feature. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
