Yicong-Huang commented on code in PR #4105: URL: https://github.com/apache/texera/pull/4105#discussion_r2594587317
########## bin/fix-format.sh: ########## @@ -95,14 +95,14 @@ fi # --- 3) Python formatting --- if $run_python; then - tx_info "Running black in amber/src/main/python..." - if ! command -v black >/dev/null 2>&1; then - tx_error "black not found. Install with: pip install black" + tx_info "Running ruff in amber/src/main/python..." + if ! command -v ruff >/dev/null 2>&1; then + tx_error "ruff not found. Install with: pip install ruff" Review Comment: here the instruction should come with the exact version of ruff ########## amber/src/main/python/pyproject.toml: ########## @@ -15,17 +15,13 @@ # specific language governing permissions and limitations # under the License. -[tool.black] +[tool.ruff] line-length = 88 -target-version = ["py39", "py310", "py311", "py312"] -extend-exclude = ''' -/( - proto -)/ -''' +target-version = "py310" Review Comment: I think it is better to always target the highest python version we support, in this case, python 3.12. @LJX2017 can you change it in a follow up PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
