aicam commented on code in PR #4113: URL: https://github.com/apache/texera/pull/4113#discussion_r2621095644
########## amber/src/main/scala/org/apache/texera/web/resource/dashboard/user/UserResource.scala: ########## @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.texera.web.resource.dashboard.user + +import org.apache.texera.dao.SqlServer +import org.apache.texera.dao.jooq.generated.tables.daos.UserDao +import org.apache.texera.dao.jooq.generated.tables.User.USER +import javax.ws.rs._ +import javax.ws.rs.core.{MediaType, Response} + +case class AffiliationUpdateRequest(uid: Int, affiliation: String) + +object UserResource { Review Comment: I realized that all endpoints related to registration are defined in `amber/src/main/scala/org/apache/texera/web/resource/GmailResource.scala`, please move them to this file to unify all user resources ########## amber/src/main/scala/org/apache/texera/web/resource/dashboard/admin/user/AdminUserResource.scala: ########## @@ -78,7 +79,8 @@ class AdminUserResource { USER.GOOGLE_AVATAR, USER.COMMENT, USER_LAST_ACTIVE_TIME.LAST_ACTIVE_TIME, - USER.ACCOUNT_CREATION_TIME + USER.ACCOUNT_CREATION_TIME, + USER.AFFILIATION Review Comment: Is there any way to make this value optional with default empty? currently all usages of User is updated in this PR simply because a new field is added which is actually optional -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
