carloea2 opened a new pull request, #4145: URL: https://github.com/apache/texera/pull/4145
### What changes were proposed in this PR? This PR fixes the value returned by `minValue` for `AttributeType.DOUBLE` in `AggregationOperation.scala`. Previously, the code used `Double.MIN_VALUE`, which is the smallest positive non-zero double, not the most-negative value. https://github.com/apache/texera/blob/07c35d004a1185e4098b56591166b62cc9ab4856/common/workflow-operator/src/main/scala/org/apache/amber/operator/aggregate/AggregationOperation.scala#L335-L345 The fix replaces `Double.MIN_VALUE` with `Double.NEGATIVE_INFINITY` and add new testing. ### Any related issues, documentation, discussions? Closes #4144 Related discussion: #4049 (Clarify minValue intent in AggregationOperation) ### How was this PR tested? - AggregateOpSpec.scala - AttributeTypeUtilsSpec.scala - Frontend Manual Test ### Was this PR authored or co-authored using generative AI tooling? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
