aglinxinyuan commented on code in PR #4158:
URL: https://github.com/apache/texera/pull/4158#discussion_r2696451966
##########
amber/src/main/scala/org/apache/texera/amber/engine/architecture/controller/WorkflowScheduler.scala:
##########
@@ -45,7 +45,7 @@ class WorkflowScheduler(
// CostBasedRegionPlanGenerator considers costs to try to find an
optimal plan.
new CostBasedScheduleGenerator(
workflowContext,
- physicalPlan,
+ physicalPlan.copy(executionMode =
workflowContext.workflowSettings.executionMode),
Review Comment:
Before doing this PR, Xiaozhen, Chen, and I discussed this and agreed that
this flag should be part of the physical plan. Given how the
CostBasedScheduleGenerator uses blocking output links in the physical plan to
reason about regions, this information belongs in the physical plan. We are not
duplicating information in the physical plan; we use this information to
generate a new physical plan. In fact, the physical plans for streaming mode
and batch mode are different, because the physical plan includes the links, and
in batch mode every output link becomes a blocking link.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
