xuang7 commented on code in PR #4177:
URL: https://github.com/apache/texera/pull/4177#discussion_r2726120633
##########
file-service/src/main/scala/org/apache/texera/service/resource/DatasetResource.scala:
##########
@@ -175,6 +176,47 @@ object DatasetResource {
normalized
}
+ /**
+ * Converts LakeFS ApiException to appropriate HTTP exception
+ */
+ private def handleLakeFSException(e: io.lakefs.clients.sdk.ApiException):
Nothing = {
+ val rawBody =
Option(e.getResponseBody).filter(_.nonEmpty).getOrElse(e.getMessage)
Review Comment:
Good point. The message may not be very sensitive in most cases, but
returning `e.getMessage` to the frontend could still leak internal details. I
have updated the handler to return simplified `fallbackMessages` to clients,
while keeping the original LakeFS error details in server logs for debugging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
