Ma77Ball commented on code in PR #4287:
URL: https://github.com/apache/texera/pull/4287#discussion_r2927528324
##########
.github/workflows/github-action-build.yml:
##########
@@ -26,14 +26,76 @@ on:
- 'ci-enable/**'
- 'main'
pull_request:
+ types: [opened, synchronize, reopened]
+ issue_comment:
+ types: [created]
Review Comment:
Yes, but this is the only plausible workaround I could think of for this
comment (https://github.com/apache/texera/pull/4278#issuecomment-4044239671).
The problem is that either:
1. We have a label that allows runs to pass through editing workflows
(causing potential security issues)
2. We have committers run workflows manually from the actions tab to bypass
security checks (not sure if this is even possible)
3. We only allow committers to make changes to workflows
4. We allow committers to run the workflow from a comment
Committers can't just rerun the failed workflow, as it will trigger a GitHub
run with the pull request owners' credentials.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
