bobbai00 commented on code in PR #4478:
URL: https://github.com/apache/texera/pull/4478#discussion_r3134224954
##########
amber/src/main/scala/org/apache/texera/amber/engine/architecture/pythonworker/PythonWorkflowWorker.scala:
##########
@@ -168,6 +168,11 @@ class PythonWorkflowWorker(
private def startPythonProcess(): Unit = {
val udfEntryScriptPath: String =
pythonSrcDirectory.resolve("texera_run_python_worker.py").toString
+ // Only forward credentials for the active iceberg catalog backend; the
+ // inactive backend's slots are passed as empty strings to keep the
+ // positional arg layout stable for texera_run_python_worker.py.
Review Comment:
remove the sentences like "to keep the positional arg layout...", The
comment should be something like "Set the Iceberg related env vars based on the
catalog type".
##########
computing-unit-managing-service/src/main/scala/org/apache/texera/service/resource/ComputingUnitManagingResource.scala:
##########
@@ -65,49 +65,65 @@ object ComputingUnitManagingResource {
.getInstance()
.createDSLContext()
+ // Iceberg env vars are gated by catalog type so each CU only receives the
Review Comment:
Such comment is unnecessary. Remove them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
