bobbai00 commented on PR #4387: URL: https://github.com/apache/texera/pull/4387#issuecomment-4320408943
> for each of the dependencies, i don't think it is sufficient to categorize the licenses just as MIT, BSD, etc and have their generic license text. i believe it needs to be the actual text of the license for at least some of these, because they contain a copyright assignment as part of the license itself. this is what i see in spark's approach of having the license folder. in asterix we also do this but instead of referring to a license folder we concatenate it all into LICENSE. e.g. for apache commons math, it contains some 3-clause BSD licensed code like this. if you removed the 2nd paragraph, you don't know who actually holds the copyright and is allowing you to use it under this license: > > ``` > Copyright and license statement for the original Mersenne twister C > routines translated in MersenneTwister class in package > org.apache.commons.math3.random: > > Copyright (C) 1997 - 2002, Makoto Matsumoto and Takuji Nishimura, > All rights reserved. > > Redistribution and use in source and binary forms, with or without > ..... > ``` > > not every license is like this though. ASL2 licensed projects usually have the same LICENSE text unless they contain 3rd party dependencies because the copyright notice is in NOTICE instead. so it will depend; you have to see if you can group dependencies or not where applicable. Fixed. Please check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
