Yicong-Huang opened a new pull request, #4506:
URL: https://github.com/apache/texera/pull/4506

   ### What changes were proposed in this PR?
   
   `TrivialControlSpec.testControl` used `probe.receiveWhile(5.minutes, 
10.seconds)` with a catch-all `case other => skip`. Because the partial 
function always matched, `receiveWhile` could only exit via the 10s idle 
timeout — so every test sat idle for ~10s after collecting all expected 
returns. With 8 tests, that was ~80s of pure waiting.
   
   Replace `receiveWhile` with a manual loop that exits as soon as `flag == 
expectedValues.length`. Behavior preserved: same per-message handling, same 
per-call 10s timeout (now via `receiveOne`), still throws `AssertionError` on 
timeout or wrong return values.
   
   ### Any related issues, documentation, discussions?
   
   Closes #4505
   
   ### How was this PR tested?
   
   Existing 8 tests in `TrivialControlSpec` all pass locally. Measured locally 
on the same worktree with a fresh sbt session:
   
   | | `Run completed in` |
   |---|---|
   | before | 1 minute, 11 seconds |
   | after  | 1 second, 16 milliseconds |
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Opus 4.7)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to