Yicong-Huang commented on PR #4531: URL: https://github.com/apache/texera/pull/4531#issuecomment-4322744668
Added a smoke test: `ExecutionReconfigurationServiceSpec` verifying the empty-short-circuit path doesn't dereference `client` or `workflow` and leaves the reconfiguration store unchanged. I deliberately scoped the unit test to that one invariant: the dispatch path that calls `controllerInterface.reconfigureWorkflow` is hard to mock at this layer (constructing `AmberClient` requires an `ActorSystem` plus an actor handshake at construction time). The engine-side `ReconfigurationSpec` already covers the controller RPC end-to-end with both Java and Python operators. Open to refactoring the constructor to take `ControllerServiceFs2Grpc[Future, Unit]` instead of the whole `AmberClient` if reviewers prefer — that would let us stub the interface cleanly. Happy to do it in a follow-up if it's preferred separate from this fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
