Yicong-Huang commented on code in PR #4424:
URL: https://github.com/apache/texera/pull/4424#discussion_r3153446137


##########
amber/src/main/python/core/runnables/main_loop.py:
##########
@@ -329,7 +330,7 @@ def _process_ecm(self, ecm_element: ECMElement):
 
             if ecm.ecm_type != EmbeddedControlMessageType.NO_ALIGNMENT:
                 self.context.pause_manager.resume(PauseType.ECM_PAUSE)
-
+            self._switch_context()

Review Comment:
   > 3. DataProcessor calls get_internal_marker() and clears the marker.
   > 4. MainLoop resumes and sees current_internal_marker is None.
   
   These steps are intentional. All those states/message should only be 
processed by one component (e.g., DP or CP), and each state/message can only be 
consumed or processed once.
   
   If you need to trigger _process_start_channel() / _process_end_channel() in 
the main loop, it requires another message. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to