Yicong-Huang commented on issue #4545: URL: https://github.com/apache/texera/issues/4545#issuecomment-4334593971
The flaky is edge case that depends on time and order, it is a race condition. It is unrealistic to guard through all of those potential race condition cases. But our design, especially python UDF design, should act as a single thread, so that if we followed the design, no race condition should happen. I am glad this specific case was caught post merge. Given the limited CI resource we have, not always we can catch bugs pre-merge. But with more CI/CD runs we could identify more cases like this post merge. That's also good enough. I will add more assertions and test cases to make per-merge CI more robust. and count on post-merge repeats to detect and alert us flaky case like this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
