Xiao-zhen-Liu commented on PR #4557: URL: https://github.com/apache/texera/pull/4557#issuecomment-4346685670
> I see there are a few recent changes with scheduler. Given its importance, I hope we can be careful on those changes. Two questions: > > 1. Can we add tests cases to verify this works as expected? also anti-test the bugging situation will not happen. > 2. Do we need this before release 1.1.0, for can this wait? This [Make region termination synchronous before scheduling the next region #4556](https://github.com/apache/texera/issues/4556) its a bug issue but described like a task. If we don't fix it, will it block users? 1. Yes test cases will be added. 2. Not needed for the release. There should be no effect on user experience before and after this PR. The previous asynchronous termination design was okay, since it does not matter (aside from the resource management part) if the next region starts before the previous region's workers are fully terminated (only the materialized results are required anyway). Synchronous termination is needed however for @aglinxinyuan 's control block work, as we need the ability to restart / reinitialize a region to be able to run an operator multiple times. It is also a cleaner design, so it is beneficial to merge it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
