aglinxinyuan commented on PR #4570: URL: https://github.com/apache/texera/pull/4570#issuecomment-4356625859
Thanks for the review @Yicong-Huang. Pushed [3675f94](https://github.com/apache/texera/pull/4570/commits/3675f94096) with 11 additional cases (15 → 26 tests, all passing): **`aggregateStates`** — defensive / precedence: - Mixed `completed + terminated` falls through to **UNKNOWN** (neither `forall` branch matches; surfaces a subtle contract that "completed and terminated together" is not the same as "all completed"). - Running takes precedence over completed/terminated; single `running` also resolves to RUNNING. - No-completed inputs still classify as PAUSED / UNINITIALIZED / RUNNING (all-ready). - A value matching none of the sentinels resolves to **UNKNOWN** rather than being silently classified. **`aggregatePortMetrics`**: - Three+ mappings on the same port summed without loss. - Multiple ports each with multiple mappings summed independently per port. - Zero-count, zero-size mapping preserved, not dropped. **`aggregateMetrics`**: - Single operator's stats preserved (modulo internal-port filter). - Running + completed pair → RUNNING. - All-completed → COMPLETED with summed scalars. - Operators with empty per-port stats coexist with non-empty ones while scalars still sum. Let me know if you'd like additional edges covered. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
