Yicong-Huang commented on issue #4603:
URL: https://github.com/apache/texera/issues/4603#issuecomment-4358543234
Reopening — PR #4604 was merged 18+ minutes ago and the opt-in had no
observable effect:
- `GET /repos/apache/texera/rulesets` → `[]`
- `GET /repos/apache/texera/rules/branches/release/v1.1.0-incubating` → `[]`
Root cause traced into `apache/infrastructure-asfyaml`:
1. The dispatcher
(`infrastructure-p6/modules/gitbox/files/asfgit/hooks/post-receive.d/05-asfyaml.py`)
routes to next-gen by default and our `meta.environment: github_rulesets`
opt-in is honored, so the `rulesets` directive does run.
2. But `_build_ref_name_condition` in `asfyaml/feature/github/rulesets.py`
does **not** prefix bare convenience patterns with `refs/heads/`. Our
`release/*` is sent as-is to the GitHub Rulesets API, which requires
`refs/heads/release/*` (or `~DEFAULT_BRANCH` / `~ALL`).
3. The reconciler's REST calls do **not** check HTTP status codes, so the
resulting 422 is silently swallowed — no email, no log, `/rulesets` stays empty.
Both bugs are being addressed in `apache/infrastructure-asfyaml` PR #93
("Follow-up fixes for the GitHub rulesets feature") which is still **open**.
`apache/logging-parent` — the only other ASF project that has tried this opt-in
— also has empty `/rulesets` for related reasons.
Reverting #4604 to keep `main` clean. Will revisit once #93 is merged
upstream, or pursue an INFRA Jira ticket (Kafka-style, INFRA-26603 precedent).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
