Yicong-Huang opened a new issue, #4653:
URL: https://github.com/apache/texera/issues/4653

   ### What happened?
   
   Root-level scala build/lint config files do not trigger the scala CI stack:
   
   - `build.sbt` (root)
   - `project/**` (sbt build sources, `plugins.sbt`)
   - `.scalafix.conf` (moved to repo root by #3888)
   - `.scalafmt.conf`
   
   A PR that only edits one of these gets `dependencies` (for `**/build.sbt`) 
plus whatever non-scala label happens to apply, then `LABEL_STACKS` (#4640) 
maps `dependencies` to no-op (#4639) — so scala does not run even though the 
change is purely a scala build/lint setting.
   
   Concrete example: PR #4649 edits root `build.sbt` (and 
`frontend/karma.conf.js`). Labels applied: `dependencies`, `fix`, `frontend`. 
Effective stack run set = {frontend}; scala skipped, even though the PR is 
testing a `jacocoReportSettings` change in the root build.
   
   ### How to reproduce?
   
   1. Open a PR that only edits root `build.sbt` (or `project/plugins.sbt` / 
`.scalafix.conf` / `.scalafmt.conf`).
   2. Wait for the labeler to apply labels.
   3. Observe: `dependencies` is the only relevant label; scala stack is 
skipped per `LABEL_STACKS`.
   
   ### Version
   
   1.1.0-incubating (Pre-release/Master)
   
   ### Commit Hash (Optional)
   
   0bfbf616d9
   
   ### Relevant log output
   
   ```
   PR labels: dependencies, fix, frontend, release/v1.1.0-incubating
   Stacks selected by label union: frontend
   ```
   
   ### Proposed fix
   
   Extend the `service` rule in `.github/labeler.yml` to include the root-level 
scala build/lint files (`build.sbt`, `project/**`, `.scalafix.conf`, 
`.scalafmt.conf`). `service` already maps to the `scala` stack in 
`LABEL_STACKS`, so the union picks up scala automatically.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to