aglinxinyuan opened a new issue, #4661:
URL: https://github.com/apache/texera/issues/4661

   ### Task Summary
   
   The root 
[`Dockerfile`](https://github.com/apache/texera/blob/main/Dockerfile) is dead 
code and should be removed. It still references paths that were renamed or 
relocated months ago, nothing in the build system points at it, and the active 
image-building path is `bin/*.dockerfile`.
   
   **Why it is broken on its own terms.** The file contains:
   
   - `COPY core/gui/package.json core/gui/yarn.lock ./` and `COPY core/gui .` — 
`core/gui/` was relocated to `frontend/` in #3851 (`chore: relocate core/gui to 
frontend`).
   - `COPY core/ .` — `core/` was renamed to `common/` in #3882 (`chore: rename 
core to common`).
   - `RUN pip3 install -r requirements.txt` and `RUN pip3 install -r 
operator-requirements.txt` — these files now live under `amber/`.
   - `FROM node:18-alpine` — the active frontend builder is `node:24-bookworm` 
in `bin/texera-web-application.dockerfile` (post #4658).
   
   The last touch was #3877 (`chore: rename core/scripts to bin`, Oct 2025), 
which only fixed one path inside this file and left the rest pointing at 
directories that no longer exist. `docker build .` against this file fails 
immediately.
   
   **Why nothing uses it.**
   
   - `.github/workflows/build-and-push-images.yml` builds images by globbing 
`bin/*.dockerfile` only.
   - `bin/build-images.sh` and `bin/merge-image-tags.sh` likewise iterate 
`*.dockerfile` from `bin/`.
   - `bin/README.md` documents `bin/*.dockerfile` as the supported pattern 
(e.g. `docker build -f bin/texera-web-application.dockerfile -t ... .`).
   - The two `docker-compose.yml` files (`bin/single-node/`, `sql/`) consume 
pre-built images and do not declare `build:` for the root `Dockerfile`.
   
   **Proposed change.** Delete the root `Dockerfile`. Keep `.dockerignore` — it 
still applies as a build-context filter for the active `bin/*.dockerfile` 
builds run from the project root.
   
   ### Priority
   
   P3 – Low
   
   ### Task Type
   
   - [ ] Code Implementation
   - [ ] Documentation
   - [x] Refactor / Cleanup
   - [ ] Testing / QA
   - [ ] DevOps / Deployment


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to