Yicong-Huang opened a new pull request, #4712: URL: https://github.com/apache/texera/pull/4712
### What changes were proposed in this PR? Adds scalatest coverage for `common/workflow-core/src/main/scala/org/apache/texera/amber/util/VirtualIdentityUtils.scala`. The module had no dedicated spec. ### Any related issues, documentation, discussions? Closes #4710. Potential bug noted while reading the module (not pinned by these tests): `getWorkerIndex` only matches `workerNamePattern` and has no fallback case, so passing a non-worker actor identity (e.g. `CONTROLLER`, `SELF`) raises `scala.MatchError` at runtime. The other parsing helpers (`getPhysicalOpId`, `toShorterString`) handle the unmatched case gracefully — `getWorkerIndex` should likely do the same. ### How was this PR tested? ``` sbt scalafmtCheckAll sbt "WorkflowCore/testOnly org.apache.texera.amber.util.VirtualIdentityUtilsSpec" ``` ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (claude-opus-4-7) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
