Yicong-Huang opened a new pull request, #4716:
URL: https://github.com/apache/texera/pull/4716

   ### What changes were proposed in this PR?
   
   Adds scalatest coverage for 
`common/workflow-core/src/main/scala/org/apache/texera/amber/util/JSONUtils.scala`.
 The module had no dedicated spec.
   
   ### Any related issues, documentation, discussions?
   
   Closes #4715.
   
   Potential bug noted while reading the module (one path is now pinned in the 
spec with an explanatory comment): the `JSONToMap` docstring claims 
`{"E":["X","Y"]}` flattens to `{"E1":"X","E2":"Y"}`, but the implementation 
only emits an entry when the recursive call iterates an *object* node, so 
primitives inside an array are silently dropped. The spec pins the actual 
current behavior (empty for the array slot) so a future fix that brings the 
code in line with the docstring will surface here and force a deliberate spec 
update.
   
   ### How was this PR tested?
   
   ```
   sbt scalafmtCheckAll
   sbt "WorkflowCore/testOnly org.apache.texera.amber.util.JSONUtilsSpec"
   ```
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (claude-opus-4-7)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to