aglinxinyuan commented on PR #4669: URL: https://github.com/apache/texera/pull/4669#issuecomment-4365054212
> > > > > > Why do we want to make this Admin-adjustable? I don't feel this makes much sense. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > It should be either fixed at a large number or user-adjustable. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > We want this parameter to be adjustable by the admins. I am OK with fixing it. > > > > > > > > > > > > > > > > > > > > > > > > > > Let's make it a large fixed number, unless there is a disadvantage for that. > > > > > > > > > > > > The disadvantage is that univocity allocates memory per parser based on that number (10,000 is negligible, but something like 1,000,000 is not when you want to scale the platform). > > > > > > This makes sense to me now. Why do we also need batch size adjustable for result table? Can we just pick a fixed number? > > > > That setting I added because the result panel settings menu seems a little empty, and I thought it might be a nice feature for users. I can remove it if it should be in a different PR or if it's not needed. Let's don't over complicate the settings. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
