Yicong-Huang opened a new pull request, #4735:
URL: https://github.com/apache/texera/pull/4735

   ### What changes were proposed in this PR?
   
   Adds pytest coverage for `amber/src/main/python/core/models/operator.py`. 
The `Operator` abstract base class had no dedicated spec.
   
   ### Any related issues, documentation, discussions?
   
   Closes #4733.
   
   Bug pinned in the spec with an explanatory comment (filed separately as a 
Bug issue): `SourceOperator` declares `__internal_is_source = True` at class 
level, but Python name-mangles that into `_SourceOperator__internal_is_source` 
while `Operator.is_source` reads `self._Operator__internal_is_source`. The two 
are different attributes, so a fresh `SourceOperator` subclass instance reports 
`is_source=False` until `ExecutorManager.initialize_executor` invokes the 
explicit setter — making the class-level declaration effectively dead code.
   
   ### How was this PR tested?
   
   ```
   cd amber/src/main/python
   ruff check core/models/test_operator.py
   ruff format --check core/models/test_operator.py
   python -m pytest core/models/test_operator.py
   ```
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (claude-opus-4-7)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to