Yicong-Huang opened a new issue, #4760:
URL: https://github.com/apache/texera/issues/4760

   ### What happened?
   
   
`common/workflow-core/src/main/scala/org/apache/texera/amber/util/ArrowUtils.scala::toAttributeType`
 matches `case 16 | 32 => INTEGER` then `case 64 | _ => LONG`. The trailing `_` 
makes the second arm a catch-all, so every Int width that isn't 16 or 32 — 
including widths smaller than 32 like 8, and widths larger than 64 like 128 — 
surfaces as `LONG`. The intent of the second arm appears to have been "true 
64-bit Int → LONG", and the `_` was redundantly added; the side effect is that 
exotic widths silently coerce to LONG with no warning.
   
   ### How to reproduce?
   
   ```scala
   import org.apache.arrow.vector.types.pojo.ArrowType
   import org.apache.texera.amber.util.ArrowUtils
   
   ArrowUtils.toAttributeType(new ArrowType.Int(8, true))   // LONG (probably 
should be INTEGER or fail)
   ArrowUtils.toAttributeType(new ArrowType.Int(64, true))  // LONG
   ArrowUtils.toAttributeType(new ArrowType.Int(128, true)) // LONG (probably 
should fail)
   ```
   
   ### Version
   
   1.1.0-incubating (Pre-release/Master)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to