Copilot commented on code in PR #4889:
URL: https://github.com/apache/texera/pull/4889#discussion_r3179258604
##########
frontend/src/app/workspace/component/result-panel/error-frame/error-frame.component.spec.ts:
##########
@@ -32,10 +32,9 @@ describe("ConsoleFrameComponent", () => {
let component: ErrorFrameComponent;
let fixture: ComponentFixture<ErrorFrameComponent>;
Review Comment:
The test suite name just above this block is "ConsoleFrameComponent" but
this spec is for ErrorFrameComponent. Renaming the describe title will make
test output and failures easier to interpret.
##########
frontend/src/app/workspace/component/workflow-editor/context-menu/context-menu/context-menu.component.spec.ts:
##########
@@ -116,6 +115,7 @@ describe("ContextMenuComponent", () => {
...commonTestProviders,
],
imports: [
+ ContextMenuComponent,
HttpClientModule,
ReactiveFormsModule,
Review Comment:
This spec imports HttpClientModule, which can allow real network requests
during unit tests and makes failures harder to diagnose. Prefer
HttpClientTestingModule (or remove the HttpClient module import entirely if
nothing in this TestBed needs it).
##########
frontend/src/app/workspace/component/workflow-editor/mini-map/mini-map.component.spec.ts:
##########
@@ -47,9 +46,9 @@ describe("MiniMapComponent", () => {
},
...commonTestProviders,
],
- imports: [HttpClientTestingModule, DragDropModule],
+ imports: [MiniMapComponent, WorkflowEditorComponent,
HttpClientTestingModule, DragDropModule],
Review Comment:
TestBed imports include WorkflowEditorComponent, but this spec only creates
MiniMapComponent (the workflow editor component isn’t referenced in the test).
Dropping unused standalone/component imports can reduce compile time and avoid
pulling extra transitive dependencies into this unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
