bobbai00 opened a new pull request, #4894:
URL: https://github.com/apache/texera/pull/4894

   ### What changes were proposed in this PR?
   
   Adds 3 unit tests to `about.component.spec.ts` covering the `*ngIf` branches 
in `about.component.html` that codecov flagged on #4890:
   
   - `<texera-local-login>` is hidden when the user is logged in.
   - It is shown when the user is logged out and `config.env.localLogin` is 
true.
   - It is hidden when the user is logged out but `config.env.localLogin` is 
false.
   
   Provides `RouterTestingModule.withRoutes([])` plus a `NotificationService` 
spy via `useValue` so the real `LocalLoginComponent` renders under TestBed 
(matching the spy-mocked `NotificationService` pattern in 
`download.service.spec.ts` and `workflow-result-export.service.spec.ts`).
   
   ### Any related issues, documentation, discussions?
   
   Sibling of #4890 (the actual `/about` layout fix). Split out of #4890 
because the release branch still uses the old frontend testing framework, and 
the layout fix needs to backport cleanly without dragging the new spec along. 
This PR targets `main` only — no backport.
   
   ### How was this PR tested?
   
   `yarn ng test --watch=false 
--include=\"src/app/hub/component/about/about.component.spec.ts\"` → 4 passed.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (claude-opus-4-7)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to