Yicong-Huang opened a new pull request, #4897:
URL: https://github.com/apache/texera/pull/4897
### What changes were proposed in this PR?
Drop 6 spec files from the exclusion lists and migrate their TestBed setups
to the standalone-component shape — `declarations: [Comp]` becomes `imports:
[Comp]`. The components are already standalone post-#4873.
Specs re-enabled:
- `dashboard/admin/execution`
- `dashboard/admin/settings`
- `dashboard/admin/user`
- `workspace/left-panel/left-panel` (also drops a `fakeAsync` `beforeEach`
wrapper that needed an outer ProxyZone; the body only used `tick()`
cosmetically)
- `workspace/left-panel/operator-menu/operator-label`
- `workspace/left-panel/operator-menu/operator-menu`
Also stubs `document.queryCommandSupported` in `jsdom-svg-polyfill.ts` so
specs that pull monaco in indirectly don't crash at module-load time.
### Specs that did NOT make it into this PR
The remaining excluded entries now fall into two clearly-labeled buckets,
captured inline in the exclude list:
**Placeholder specs (body entirely commented out — need real test cases
written):**
- `common/formly/preset-wrapper`
- `common/service/user/config/user-config`
- `workspace/left-panel/settings`
- `workspace/menu/menu`
- `workspace/workspace.component`
- `workspace/service/preset/preset.service`
**Blocked on jsdom limitations (belong under Vitest browser mode #4866):**
- `code-editor-dialog/code-debugger`, `code-editor` — monaco CSS +
`queryCommandSupported`
- `codearea-custom-template` — monaco CSS
- `left-panel/time-travel`, `versions-list` — `monaco-breakpoints` imports a
`.css` file Vitest can't transform
- `property-editor/operator-property-edit-frame` — formly+nz fetches
`snippets-o` icon over HTTP
- `workflow-editor/workflow-editor` — jointjs paper math needs real
`getScreenCTM`
- `dashboard/dashboard.component` — `<asl-google-signin-button>`
dereferences fields a minimal `SocialAuthService` mock doesn't provide
- `user-project-list-item`, `user-workflow-list-item`,
`user-workflow.component` — templates rooted at `<nz-list-item>` need a
`<nz-list>` host wrapper
### Any related issues, documentation, discussions?
A slice of #4880 — closes the standalone-migration sweep portion of that
effort.
### How was this PR tested?
`yarn ng test --watch=false` locally:
```
Test Files 52 passed | 3 skipped (55)
Tests 227 passed | 8 skipped | 2 todo (237)
```
Up from 46 / 216 on main.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.7 (1M context)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
