Yicong-Huang opened a new pull request, #4944:
URL: https://github.com/apache/texera/pull/4944
### What changes were proposed in this PR?
Drop 4 entries from the spec exclusion lists in `tsconfig.spec.json` and
`angular.json`'s test target, port their TestBed setups to the
standalone-component shape, and fix one malformed template attribute that jsdom
won't tolerate.
**Specs re-enabled:**
- `dashboard.component.spec.ts` — extends `socialAuthServiceMock` with
`initState` (the Google sign-in directive subscribes to it in its constructor)
and adds an `AdminSettingsService` stub; switches to `imports:
[DashboardComponent]` so its standalone graph carries
`GoogleSigninButtonModule` instead of relying on `NO_ERRORS_SCHEMA`.
- `user-project-list-item.component.spec.ts` — wraps the component in a
`TestHostComponent` template `<nz-list><texera-user-project-list-item
.../></nz-list>` so the `<nz-list-item>`-rooted component finds an
`NzListComponent` provider; adds `provideRouter([])` for the embedded
`[routerLink]`.
- `user-workflow-list-item.component.spec.ts` — same `<nz-list>` host
wrapper.
- `user-workflow.component.spec.ts` — switches `declarations: [...]` to
`imports: [...]` for the now-standalone children; converts
`beforeEach(waitForAsync(...))` to `beforeEach(async () => ...)` so the setup
runs outside the per-`it` ProxyZone wrapper.
**Drive-by template fix:**
`user-workflow.component.html` had a stray `]="true"` line — left over from
#4873's `[nzBorderless]="true"` → `nzVariant="borderless"` rewrite. Browsers
silently tolerate the malformed attribute, but jsdom throws
`InvalidCharacterError: "]" did not match the Name production` during
`setAttribute`, which is why the spec couldn't run under Vitest.
After this PR, the exclude list contains only specs gated on Vitest browser
mode (#4866) or specs whose body is still a placeholder.
### Any related issues, documentation, discussions?
Part of #4880.
### How was this PR tested?
`yarn install && yarn ng test --watch=false` exits 0 locally; `yarn
format:ci` is clean. CI exercises the same test command on the ubuntu / windows
/ macos frontend matrices.
```
Test Files 56 passed | 3 skipped (59)
Tests 248 passed | 8 skipped | 2 todo (258)
```
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.7 (1M context)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
