aglinxinyuan commented on code in PR #4490:
URL: https://github.com/apache/texera/pull/4490#discussion_r3205327630
##########
amber/src/main/scala/org/apache/texera/amber/engine/architecture/messaginglayer/OutputManager.scala:
##########
@@ -251,7 +264,10 @@ class OutputManager(
writerThread.getFailure.foreach(throw _)
case None =>
}
-
+ this.stateWriterThreads.remove(outputPortId).foreach { writerThread =>
Review Comment:
Good catch — fixed in 990acdf. Mirrored the `getFailure.foreach(throw _)` on
the state-writer cleanup so a state-side iceberg commit failure now surfaces as
a FatalError too instead of being silently swallowed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
