Yicong-Huang commented on PR #4988: URL: https://github.com/apache/texera/pull/4988#issuecomment-4422961554
> These two tests are testing the createRestCatalog in Scala and python. so this PR is covered end-to-end. With CI passed, I think we can confirm that this change works. sg. thanks! let's also make sure the coverage is filled ><!DOCTYPE html><head></head><p dir="auto" style="box-sizing: border-box; margin-top: 0px; margin-bottom: var(--base-size-16);">❌ Patch coverage is<span class="Apple-converted-space"> </span><code class="notranslate" style="box-sizing: border-box; font-family: var(--fontStack-monospace,ui-monospace, SFMono-Regular, SF Mono, Menlo, Consolas, Liberation Mono, monospace); font-size: 11.9px; tab-size: var(--tab-size-preference); white-space: break-spaces; background-color: var(--bgColor-neutral-muted,var(--color-neutral-muted)); border-radius: 6px; margin: 0px; padding: 0.2em 0.4em;">0%</code><span class="Apple-converted-space"> </span>with<span class="Apple-converted-space"> </span><code class="notranslate" style="box-sizing: border-box; font-family: var(--fontStack-monospace,ui-monospace, SFMono-Regular, SF Mono, Menlo, Consolas, Liberation Mono, monospace); font-size: 11.9px; tab-size: var(--tab-size-preference); white-space: break-spaces; background-color: var(--bgColor-neutr al-muted,var(--color-neutral-muted)); border-radius: 6px; margin: 0px; padding: 0.2em 0.4em;">3 lines</code><span class="Apple-converted-space"> </span>in your changes missing coverage. Please review.<br style="box-sizing: border-box;">✅ Project coverage is 42.75%. Comparing base (<a href="https://app.codecov.io/gh/apache/texera/commit/14f8be4c0856dd9f0be2aa594bdfe46a92f9d4cd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache"; rel="nofollow" style="box-sizing: border-box; background-color: rgba(0, 0, 0, 0); color: var(--fgColor-accent,var(--color-accent-fg)); text-decoration: underline; text-underline-offset: 0.2rem;"><code class="notranslate" style="box-sizing: border-box; font-family: var(--fontStack-monospace,ui-monospace, SFMono-Regular, SF Mono, Menlo, Consolas, Liberation Mono, monospace); font-size: 11.9px; tab-size: var(--tab-size-preference); white-space: break-spaces; backg round-color: var(--bgColor-neutral-muted,var(--color-neutral-muted)); border-radius: 6px; margin: 0px; padding: 0.2em 0.4em;">14f8be4</code></a>) to head (<a href="https://app.codecov.io/gh/apache/texera/commit/b7b3f8440de654510ed22cf9e291c655b0ee7dbb?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache"; rel="nofollow" style="box-sizing: border-box; background-color: rgba(0, 0, 0, 0); color: var(--fgColor-accent,var(--color-accent-fg)); text-decoration: underline; text-underline-offset: 0.2rem;"><code class="notranslate" style="box-sizing: border-box; font-family: var(--fontStack-monospace,ui-monospace, SFMono-Regular, SF Mono, Menlo, Consolas, Liberation Mono, monospace); font-size: 11.9px; tab-size: var(--tab-size-preference); white-space: break-spaces; background-color: var(--bgColor-neutral-muted,var(--color-neutral-muted)); border-radius: 6px; margin: 0px; padding: 0.2em 0.4em;">b7b3 f84</code></a>).</p><markdown-accessiblity-table data-catalyst="" style="box-sizing: border-box; display: block;"> Files with missing lines | Patch % | Lines -- | -- | -- ...ala/org/apache/texera/amber/util/IcebergUtil.scala | 0.00% | 3 Missing ⚠️ </markdown-accessiblity-table><details style="box-sizing: border-box; display: block; margin-top: 0px; margin-bottom: var(--base-size-16);"></span><br class="Apple-interchange-newline">❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review. ✅ Project coverage is 42.75%. Comparing base ([14f8be4](https://app.codecov.io/gh/apache/texera/commit/14f8be4c0856dd9f0be2aa594bdfe46a92f9d4cd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([b7b3f84](https://app.codecov.io/gh/apache/texera/commit/b7b3f8440de654510ed22cf9e291c655b0ee7dbb?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). [Files with missing lines](https://app.codecov.io/gh/apache/texera/pull/4988?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Patch % Lines [...ala/org/apache/texera/amber/util/IcebergUtil.scala](https://app.codecov.io/gh/apache/texera/pull/4988?src=pr&el=tree&filepath=common%2Fworkflow-core%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Ftexera%2Famber%2Futil%2FIcebergUtil.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3dvcmtmbG93LWNvcmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS90ZXhlcmEvYW1iZXIvdXRpbC9JY2ViZXJnVXRpbC5zY2FsYQ==) 0.00% [3 Missing ⚠️](https://app.codecov.io/gh/apache/texera/pull/4988?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
