Ma77Ball commented on code in PR #5006:
URL: https://github.com/apache/texera/pull/5006#discussion_r3229267391
##########
common/workflow-core/src/main/scala/org/apache/texera/amber/util/VirtualIdentityUtils.scala:
##########
@@ -72,6 +72,9 @@ object VirtualIdentityUtils {
workerId.name match {
case workerNamePattern(_, _, _, idx) =>
idx.toInt
+ case _ =>
+ // for special actorId such as SELF, CONTROLLER
+ -1
Review Comment:
I added the Option[Int] version and changed each call site.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]