Ma77Ball opened a new pull request, #5073:
URL: https://github.com/apache/texera/pull/5073
### What changes were proposed in this PR?
`DatasetFileDocument.get_presigned_url` previously returned
`response.json().get("presignedUrl")` on a 200 response, so a body that omitted
the key (or wasn't valid JSON) silently returned `None`. This PR parses the
JSON inside a try/except block and validates that `presignedUrl` is a non-empty
string; otherwise, it raises `RuntimeError` with the response body.
### Any related issues, documentation, or discussions?
Closes: #4725
### How was this PR tested?
Manually reproduced the missing-key case (mocked 200 + empty JSON) and
confirmed the new `RuntimeError` is raised at the presign step instead of a
downstream `requests.get(None)` failure.
### Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.7 in compliance with ASF
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
