Ma77Ball opened a new pull request, #5076:
URL: https://github.com/apache/texera/pull/5076
### What changes were proposed in this PR?
On Python 3.13, the
`core/proxy/test_proxy_client.py::test_client_can_shutdown_server` test
intermittently failed with `pyarrow._flight.FlightUnavailableError: Broken
pipe` because the registered `shutdown` action spawned a thread that called
`super().shutdown()` while pyarrow was still flushing the `"Bye bye!"` reply.
The handler is now a no-op, and `ProxyServer.do_action` launches the shutdown
thread only after `yield Result(...)`, so the reply is handed to gRPC before
the listener closes. This is a causal fix, not a timing buffer, and works on
every supported Python version.
### Any related issues, documentation, or discussions?
Closes: #4650
### How was this PR tested?
Ran `pytest src/test/python/core/proxy/` on Python 3.13 (11/11 passing)
and repeated the previously flaky `test_client_can_shutdown_server` 10
consecutive times with no failures; `ruff check` and `ruff format --check` over
`amber/src/{main, test}/python` both pass, matching CI.
### Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.7 in compliance with ASF
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
