mengw15 commented on code in PR #5092:
URL: https://github.com/apache/texera/pull/5092#discussion_r3252286759


##########
amber/src/main/python/core/storage/iceberg/iceberg_document.py:
##########
@@ -211,9 +212,9 @@ def _seek_to_usable_file(self) -> Iterator[FileScanTask]:
                             self.num_of_skipped_records += record_count
                             continue
                         yield task
-                except Exception:
-                    print("Could not read iceberg table:\n")
-                    raise Exception
+                except Exception as err:
+                    logger.exception(err)
+                    raise

Review Comment:
   Added a small mocked regression test in 094d060 — patches 
`load_table_metadata` to inject a `refresh()` failure and asserts the caller 
observes the original `RuntimeError`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to