mengw15 opened a new pull request, #5132:
URL: https://github.com/apache/texera/pull/5132

   ### What changes were proposed in this PR?
   
   On the logged-out About page, the sign-in panel was rendered inside the 
`.content` column with `position: absolute; top: 130px; right: 0;`. Because the 
absolutely-positioned panel was removed from layout flow, the surrounding `<p>` 
description and `<h2>` headings had no right-side reserved space and flowed 
underneath the panel, leaving the right edge of the text visually overlapped 
(see #5126 screenshot).
   
   This PR restructures the page so the title + description still span the full 
content width, and adds a sub-row that places the feature-list column 
side-by-side with the sign-in column:
   
   - Drop the unused outer `nz-row` on `.about-page-container` and the unused 
`nz-col` on `.content` (they only ever held one child, so the flex grid was 
inert).
   - Introduce a `.features-row` inside `.content` that pairs the feature-list 
(`nzFlex="auto"`) with a 350px sign-in column. The workflow-GUI screenshot and 
Learn More section stay below at full width.
   - Replace `position: absolute; top: 130px; right: 0; max-width: 350px; 
width: 100%;` on `.login-container` with a normal-flow `margin-top: 10px;` so 
its top aligns with the feature-list `<h2>`.
   - Loosen `.content > h2` to `.content h2` so the (now-nested) feature 
heading still gets the 10px top margin.
   
   On viewports narrow enough that 350px + auto cannot fit side-by-side, 
`nz-row`'s default `flex-wrap: wrap` lets the sign-in column drop below the 
feature list rather than overlap it.
   
   ### Any related issues, documentation, discussions?
   
   Closes #5126.
   
   ### How was this PR tested?
   
   CSS / template-only layout change. No automated test added — a unit test 
would only assert that `*ngIf` toggles a DOM node, which is a tautology of the 
template. Verified locally on the logged-out About page: title + description 
span the full width, feature-list and sign-in panel sit side by side, content 
no longer slides under the panel, and dragging the window narrow makes the 
panel wrap below instead of overflowing.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (claude-opus-4-7)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to