Yicong-Huang commented on code in PR #5150:
URL: https://github.com/apache/texera/pull/5150#discussion_r3290056120
##########
amber/src/main/scala/org/apache/texera/amber/engine/architecture/worker/managers/StatisticsManager.scala:
##########
@@ -30,11 +30,11 @@ import
org.apache.texera.amber.engine.architecture.worker.statistics.{
import scala.collection.mutable
class StatisticsManager {
- // DataProcessor
+ // Plain maps (no withDefaultValue) so they survive Kryo round-trip.
private val inputStatistics: mutable.Map[PortIdentity, (Long, Long)] =
- mutable.Map.empty.withDefaultValue((0L, 0L))
+ mutable.Map.empty
Review Comment:
are there backport compatible issue? I believe we store those statistics in
DB. previously for an empty execution (if we can produce one), it will have 0L,
0L in the statistics. Although I think this fix is the right direction, I
wonder if we can also be compatible with the existing records in DB, or how to
clean them if there are any.
##########
amber/src/main/scala/org/apache/texera/amber/engine/architecture/worker/managers/StatisticsManager.scala:
##########
@@ -30,11 +30,11 @@ import
org.apache.texera.amber.engine.architecture.worker.statistics.{
import scala.collection.mutable
class StatisticsManager {
- // DataProcessor
+ // Plain maps (no withDefaultValue) so they survive Kryo round-trip.
Review Comment:
why change this comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
