PG1204 commented on PR #5146: URL: https://github.com/apache/texera/pull/5146#issuecomment-4523904455
> > @Yicong-Huang I have added a comment above regarding the test file & code coverage. > > just saw it, sorry. sg, you can place the tests else where for now, or simply add the tests in the same file and comment out the previous tests. Quick clarification on Option 2, since workflow-editor.component.spec.ts is currently in angular.json's exclude list, commenting out the previous tests by itself wouldn't make the file run in CI (so Codecov would still report 0% on the new tests). Were you implicitly suggesting I also remove the exclusion as part of this, or would you prefer that change be left out of this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
