mengw15 opened a new issue, #5163:
URL: https://github.com/apache/texera/issues/5163

   ### What happened?
   
   Shared a dataset with my own email on hub.texera.io. The notification email 
body said:
   
   > ... access the dataset at 
https://hub.texera.io/dashboard/user/**workflow**/<did>
   
   The path segment is `workflow` but should be `dataset` — clicking the link 
doesn't land on the shared dataset.
   
   Root cause — 
[`share-access.component.ts:193`](https://github.com/apache/texera/blob/a820f6727/frontend/src/app/dashboard/component/user/share-access/share-access.component.ts#L193):
   
   ```typescript
   if (this.type !== "computing-unit")
     message += `, access the ${this.type} at 
${location.origin}/dashboard/user/workflow/${this.id}`;
   //                                                                           
 ^^^^^^^^ hardcoded
   ```
   
   The dialog is invoked with `type: "dataset"` (see 
`user-dataset-list-item.component.ts:122`), but the URL path segment is 
hardcoded `workflow`.
   
   **Fix:** branch on `this.type` to pick the right route. 
`app-routing.constant.ts:33-37` already defines `DASHBOARD_USER_WORKFLOW` and 
`DASHBOARD_USER_DATASET`.
   
   Related: PR #4200 fixed the missing `/dashboard/user/` prefix (issue #3583); 
this is the remaining defect on the same line.
   
   ### How to reproduce?
   
   Share any dataset via the dashboard share dialog with your own email. 
Confirmed on hub.texera.io (2026-05-22).
   
   ### Version
   
   1.1.0-incubating (Pre-release/Master)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to