Ma77Ball commented on code in PR #5077:
URL: https://github.com/apache/texera/pull/5077#discussion_r3293797186
##########
AGENTS.md:
##########
@@ -83,8 +83,16 @@ One Python venv shared across worktrees, sibling of the
texera checkout:
```bash
python3.12 -m venv ../venv312 && source ../venv312/bin/activate
pip install -r amber/requirements.txt -r amber/operator-requirements.txt
+# For pytest or sbt-driven Python codegen, also install dev deps:
+pip install -r amber/dev-requirements.txt
```
+`amber/src/main/python/proto/` is gitignored and regenerated by the
+`genPythonProto` sbt task in [`amber/build.sbt`](amber/build.sbt), which
+runs as part of `sbt amber/compile` (or `sbt amber/genPythonProto`
+directly). Requires `protoc` on PATH (pin to `3.19.4` to match
+`PB.protocVersion`); skipped with a warning when `protoc` is missing.
Review Comment:
removed
##########
bin/computing-unit-worker.dockerfile:
##########
@@ -37,14 +37,27 @@ COPY build.sbt build.sbt
COPY .jvmopts .jvmopts
# Update system and install dependencies. python3-minimal is needed by
-# bin/licensing/concat_license_binary.py below.
+# bin/licensing/concat_license_binary.py below; python3-pip + curl are
+# for the protoc + betterproto[compiler] install below.
RUN apt-get update && apt-get install -y \
netcat \
unzip \
+ curl \
libpq-dev \
python3-minimal \
+ python3-pip \
&& apt-get clean
+# protoc 3.19.4 (matches PB.protocVersion in amber/build.sbt) and the
+# betterproto plugin are required by the genPythonProto sbt task so the
+# generated amber/src/main/python/proto/ tree is populated before the
+# dist is packaged.
+RUN curl -fsSL -o /tmp/protoc.zip
https://github.com/protocolbuffers/protobuf/releases/download/v3.19.4/protoc-3.19.4-linux-x86_64.zip
\
+ && unzip -o /tmp/protoc.zip -d /usr/local \
+ && chmod +x /usr/local/bin/protoc \
+ && rm /tmp/protoc.zip \
+ && pip3 install --no-cache-dir 'betterproto[compiler]==2.0.0b7'
Review Comment:
Pin lives only in amber/dev-requirements.txt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
